[U-Boot] [PATCH v5 6/9] Create a single cmd_call() function to handle command execution

[Simon Glass]

Hi Mike,

On Mon, Mar 5, 2012 at 8:40 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Wednesday 15 February 2012 00:59:23 Simon Glass wrote:
>> --- a/common/command.c
>> +++ b/common/command.c
>>
>> +int cmd_call(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>> +{
>> +     int result;
>> +
>> +     result = (cmdtp->cmd)(cmdtp, flag, argc, argv);
>> +     if (result)
>> +             debug("Command failed, result=%d", result);
>> +     return result;
>> +}
>
> be nice to actually display the command's name here ...

OK I can do that.

>
>> --- a/include/command.h
>> +++ b/include/command.h
>> @@ -150,4 +152,5 @@ extern int do_reset(cmd_tbl_t *cmdtp, int flag, int
>> argc, char * const argv[]); #if defined(CONFIG_NEEDS_MANUAL_RELOC)
>>  void fixup_cmdtable(cmd_tbl_t *cmdtp, int size);
>>  #endif
>> +
>>  #endif       /* __COMMAND_H */
>
> unrelated whitespace change

Done. I will send a new version of this patch and mark the dropped one
'archived' in patchwork. Do you think that is enough?

I wonder who is going to pick up this series? Stefan pulled it through
staging last time but it had a problem with true/false handling I
think, when Wolfgang tested it.

Regards,
Simon

> -mike