[U-Boot] [PATCH 1/4] doc: Add documentation for mpc85xx debugger support
Wolfgang Denk
wd at denx.de
Tue Mar 6 15:39:23 CET 2012
Dear Prabhakar Kushwaha,
In message <1329296027-28471-1-git-send-email-prabhakar at freescale.com> you wrote:
> This describes requirement of e500 and e500v2 processor to support any
> debugger. it also provide an insight of switch used and defined.
>
> Signed-off-by: Radu Lazarescu <radu.lazarescu at freescale.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar at freescale.com>
> ---
> Applies on http://git.denx.de/u-boot.git branch master
>
> doc/README.mpc85xx_debugger | 44 +++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 44 insertions(+), 0 deletions(-)
> create mode 100644 doc/README.mpc85xx_debugger
This document contains a number of typos and othe rerrors, mixed with
inconsitent indentation (some lines use TABs, others use spaces).
I suggest you clean it up and have it reviewed by a native speaker
before resubmitting.
Regarding the split into 4 separate patches: this makes no sense to
me. For example, in this patch you reference new (and undocumented
config options like CONFIG_E500_V1_V2) without ever using them.
Please squash patches.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The two most common things in the universe are hydrogen and stupi-
dity."
More information about the U-Boot
mailing list