[U-Boot] [PATCH v4 05/13] Move memcpy(), memset() into new lib/membasic.c

[Mike Frysinger]

On Tuesday 06 March 2012 01:34:24 Simon Glass wrote:
> On Mon, Mar 5, 2012 at 9:05 PM, Mike Frysinger wrote:
> > On Monday 20 February 2012 20:32:47 Simon Glass wrote:
> >> These basic functions are needed by relocation. To avoid bringing in all
> >> string.c functions (and the resulting code bloat for architectures where
> >> -ffunction-sections is not used), move these into their own file.
> > 
> > seems like fixing -f{data,function}-sections would be a more useful goal.
> >  i don't know why arm doesn't support this today ... it's fairly easy to
> > do.
> 
> I did enable it for Tegra at one point with no ill effects except for
> breaking warmboot, which relied on function ordering. I notice the
> no-toplevel-reorder flag on x86 but not with ARM. But I assumed there
> must be some reason it is not used and thought this patch safer, since
> it is just a minor tweak on a series that has has some review.

if we keep assuming that, then it'll never get fixed, and we'll sit on a steady 
stream of "small safe patches".  plus, fixing this yields general improvements 
in anti-bloat for everyone.

function ordering sounds like something that should be imposed at the linker 
level ... for Blackfin, all i had to care about was the entry point was at the 
start of the .text, although warmbooting is fairly low level magic, and i 
handle that in the SPL-like core.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120306/180a8acf/attachment.pgp>