[U-Boot] [PATCH V2] net: fec_mxc: allow use with cache enabled

[Marek Vasut]

Dear Eric Nelson,

> On 03/06/2012 10:06 AM, Eric Nelson wrote:
> > On 03/05/2012 01:06 PM, Marek Vasut wrote:
> >> Dear Eric Nelson,
> >> 
>  >> <snip>
>  >> 
> >>> + if (!fec->rbd_base) {
> >>> + ret = -ENOMEM;
> >>> + goto err2;
> >>> + }
> >>> + memset(fec->rbd_base, 0, size);
> >>> + }
> >> 
> >> We might want to flush the descriptors to memory after they have been
> >> inited?
> 
> We're also missing a flush after the call to fec_rbd_init().

I think we need only one flush in the whole allocation sequence. But you're 
probably right here.
> 
> I'm inclined to move that call to right after the memset and before
> a newly-added flush and do the same with the call to tbd_init().

You mean into fec_rbd_init() ?

Best regards,
Marek Vasut