[U-Boot] [PATCH v5 9/9] Convert cmd_usage() calls in common to use a return value

Wolfgang Denk wd at denx.de
Tue Mar 6 21:11:16 CET 2012


Dear Simon Glass,

In message <1329285566-30386-10-git-send-email-sjg at chromium.org> you wrote:
> Change all files in common/ to use CMD_RET_USAGE instead of calling
> cmd_usage() directly. This saves about 100 byte or so on ARM.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> Changes in v2:
> - Fix minor errors one of which created a warning
> - Squash i2c patch into the common/ patch
> 
> Changes in v3:
> - Rebase to master
> 
>  common/cmd_bedbug.c            |    4 ++--
>  common/cmd_bmp.c               |    6 +++---
>  common/cmd_boot.c              |    2 +-
>  common/cmd_bootm.c             |    4 ++--
>  common/cmd_cache.c             |    4 ++--
>  common/cmd_dataflash_mmc_mux.c |    2 +-
>  common/cmd_date.c              |    3 +--
>  common/cmd_dcr.c               |    8 ++++----
>  common/cmd_df.c                |    2 +-
>  common/cmd_eeprom.c            |    2 +-
>  common/cmd_ext2.c              |    4 ++--
>  common/cmd_fdc.c               |    2 +-
>  common/cmd_fdos.c              |    2 +-
>  common/cmd_fdt.c               |   14 +++++++-------
>  common/cmd_fitupd.c            |    2 +-
>  common/cmd_flash.c             |   14 +++++++-------
>  common/cmd_fpga.c              |    4 ++--
>  common/cmd_gpio.c              |    2 +-
>  common/cmd_i2c.c               |   32 ++++++++++++++++----------------
>  common/cmd_ide.c               |   10 +++++-----
>  common/cmd_irq.c               |    2 +-
>  common/cmd_itest.c             |    2 +-
>  common/cmd_led.c               |    6 +++---
>  common/cmd_load.c              |    2 +-
>  common/cmd_log.c               |    4 ++--
>  common/cmd_md5sum.c            |    2 +-
>  common/cmd_mdio.c              |    2 +-
>  common/cmd_mem.c               |   22 +++++++++++-----------
>  common/cmd_mfsl.c              |   10 +++++-----
>  common/cmd_mgdisk.c            |    2 +-
>  common/cmd_mii.c               |    4 ++--
>  common/cmd_misc.c              |    2 +-
>  common/cmd_mmc.c               |   14 +++++++-------
>  common/cmd_mmc_spi.c           |    3 +--
>  common/cmd_mp.c                |    8 ++++----
>  common/cmd_mtdparts.c          |    2 +-
>  common/cmd_nand.c              |    6 +++---
>  common/cmd_net.c               |    6 +++---
>  common/cmd_nvedit.c            |   22 +++++++++++-----------
>  common/cmd_onenand.c           |   12 ++++++------
>  common/cmd_otp.c               |    2 +-
>  common/cmd_pci.c               |    2 +-
>  common/cmd_portio.c            |    4 ++--
>  common/cmd_pxe.c               |    8 ++++----
>  common/cmd_reiser.c            |    4 ++--
>  common/cmd_sata.c              |    8 ++++----
>  common/cmd_scsi.c              |   15 ++++++++-------
>  common/cmd_setexpr.c           |    2 +-
>  common/cmd_sf.c                |    2 +-
>  common/cmd_sha1sum.c           |    2 +-
>  common/cmd_strings.c           |    2 +-
>  common/cmd_time.c              |    4 ++--
>  common/cmd_ubi.c               |    4 ++--
>  common/cmd_ubifs.c             |   10 +++++-----
>  common/cmd_unzip.c             |    2 +-
>  common/cmd_usb.c               |    6 +++---
>  common/main.c                  |    2 +-
>  57 files changed, 167 insertions(+), 168 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It may be bad manners to talk with your mouth full, but it isn't  too
good either if you speak when your head is empty.


More information about the U-Boot mailing list