[U-Boot] [PATCH v3] net: allow setting env enetaddr from net device setting

Wolfgang Denk wd at denx.de
Tue Mar 6 21:33:58 CET 2012

Dear Rob,

In message <4F566D05.5020809 at gmail.com> you wrote:
> >> +3. Write value to environment if setup in struct eth_device->enetaddr by driver
> >> +   initialize() function. Give priority to the value in the environment if a
> >> +   conflict.
> > 
> > Sorry, but this description is not correct.  You say here that the
> > environment variable should always be written, but this is not the
> > case.  Only if it does not exist it shall be set.  If it exists, it
> > shall only be read, and in case of inconsistencies a warning shall be
> > printed.
> How about this:
> 3. Always use the value in the environment if there is a conflict. If
> the environment variable is not set and the driver initialized struct
> eth_device->enetaddr, then print a warning and set the environment
> variable to initialized by the driver.

I find you make it difficult to read without need by explaining it

	The environment variable will be compared to the driver
	initialized struct eth_device->enetaddr. If they differ, a
	warning is printed, an the environment variable will be used

	If the environment variable is not set, it will be initialized
	from eth_device->enetaddr, and a warning will be printed.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Ninety-Ninety Rule of Project Schedules:
        The first ninety percent of the task takes ninety percent of
the time, and the last ten percent takes the other ninety percent.

More information about the U-Boot mailing list