[U-Boot] [PATCH 3/4] powerpc/85xx:Update NOR code base to support debugger

[Wolfgang Denk]

Dear Prabhakar Kushwaha,

In message <4F56DEB0.6060500 at freescale.com> you wrote:
> 
> >> +	_mas0 = MAS0_TLBSEL(1) |
> >> +			MAS0_ESEL(CONFIG_DEBUGGER_TEMP_TLB);
> > You are using an undocumented CONFIG_ option here.
> 
> This CONFIG_ is defined as part of documentation patch sent in this series

CONFIG_ options must be documented in the README.

> >> +#if defined(CONFIG_E500_V1_V2)&&  !defined(CONFIG_SYS_RAMBOOT)
> > What if no such debug support is needed, and code size hurts?
> 
> sure it will. I agree with you.
> But this piece of code overcome debug restriction of e500 and e500v2 
> cores and  I think fixing restriction is a good way to go.

What do we do to disable this code if no debug support is needed, and
the code size is considered critical?

> >> +#define CONFIG_DEBUGGER_TEMP_TLB	3
> > Undocumented!
> >
> This CONFIG_ is defined as part of documentation patch sent in this series

This is not sufficient, see above.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Virtue is a relative term.
	-- Spock, "Friday's Child", stardate 3499.1