[U-Boot] [PATCH 03/25] SPEAr: Place ethaddr write and read within CONFIG_CMD_NET

[Stefan Roese]

On Wednesday 07 March 2012 13:03:52 Amit Virdi wrote:
> From: Vipin KUMAR <vipin.kumar at st.com>
> 
> ethaddr can be optionally read from i2c memory. So, chip_config command
> supports reading/writing hw mac id into i2c memory. Placing this code
> within CONFIG_CMD_NET as this would only be needed when network interface
> is configured
> 
> Signed-off-by: Vipin Kumar <vipin.kumar at st.com>
> Signed-off-by: Amit Virdi <amit.virdi at st.com>

I'm not really sure, why you have this special ethaddr handling in I2C prom 
here at all. Isn't it enough to have the MAC address (ethaddr) stored in the 
U-Boot environment (NOR, NAND, etc)? Why do you need this additional I2C 
stuff? Could you please explain this?

Thanks,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de