[U-Boot] [PATCH 18/25] SPEAr: Correct the definition of CONFIG_SYS_MONITOR_BASE

[Stefan Roese]

On Wednesday 07 March 2012 13:04:07 Amit Virdi wrote:
> From: Vipin Kumar <vipin.kumar at st.com>
> 
> The below text is copy pasted from README
> - CONFIG_SYS_MONITOR_BASE:
> 	Physical start address of boot monitor code (set by
> 	make config files to be same as the text base address
> 	(TEXT_BASE) used when linking) - same as
> 	CONFIG_SYS_FLASH_BASE when booting from flash.
> 
> This patch corrects the definition of CONFIG_SYS_MONITOR_BASE and sets it
> to TEXT_BASE
> 
> Signed-off-by: Vipin Kumar <vipin.kumar at st.com>
> Signed-off-by: Amit Virdi <amit.virdi at st.com>
> ---
>  include/configs/spear-common.h |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/include/configs/spear-common.h
> b/include/configs/spear-common.h index 26642f1..0998157 100644
> --- a/include/configs/spear-common.h
> +++ b/include/configs/spear-common.h
> @@ -168,8 +168,7 @@
>  						"0x4C0000; bootm 
0x1600000"
>  #endif
> 
> -#define CONFIG_SYS_MONITOR_BASE			
CONFIG_SYS_FLASH_BASE
> -#define CONFIG_ENV_ADDR				
(CONFIG_SYS_MONITOR_BASE + \
> +#define CONFIG_ENV_ADDR				
(CONFIG_SYS_FLASH_BASE + \
>  						CONFIG_SYS_MONITOR_LEN)
>  #elif defined(CONFIG_ENV_IS_IN_NAND)
>  /*
> @@ -206,6 +205,8 @@
> 
> 
>  #define CONFIG_ENV_SIZE				0x02000
> +#define CONFIG_SYS_MONITOR_BASE			CONFIG_SYS_TEXT_BASE
> +#define CONFIG_MONITOR_IS_IN_RAM		1

Why is CONFIG_MONITOR_IS_IN_RAM defined? And if really needed, please without 
the 1.

Thanks,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de