[U-Boot] [PATCH v5 5/9] tegra: i2c: Add I2C driver

[Simon Glass]

Hi Stephen,

On Wed, Mar 7, 2012 at 12:46 PM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 03/06/2012 10:00 PM, Simon Glass wrote:
>> From: Yen Lin <yelin at nvidia.com>
>>
>> Add basic i2c driver for Tegra2 with 8- and 16-bit address support.
>> The driver requires CONFIG_OF_CONTROL to obtain its configuration
>> from the device tree.
>>
>> (Simon Glass: sjg at chromium.org modified for upstream)
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>
> I'm not sure whether i2c_init_board() correctly detects I2C bus ID
> assignment conflicts between nodes with the "-i2c" and "-i2c-dvc"
> compatible values, but I think that only affects cases where the .dts
> file is already wrong, so it's probably not a big deal.

That logic is in fdtdec, and at some point in the various series I do
add a check for this.

>
> Aside from that, I did a very very brief review. So,
>
> Acked-by: Stephen Warren <swarren at wwwdotorg.org>

Thanks.

Regards,
Simon