[U-Boot] [PATCH v2 1/4] ns16550: Add function to drain serial output

Wolfgang Denk wd at denx.de
Sat Mar 10 09:19:23 CET 2012

Dear Simon Glass,

In message <1331325178-14634-1-git-send-email-sjg at chromium.org> you wrote:
> Sometimes we want to be sure that the output FIFO has fully drained (e.g.
> because we are about to reset or the port or reset the board). Add a

Seems there is one unintentional "or".

> function for this.
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> Changes in v2:
> - Add function to drain the ns16550's FIFO
>  drivers/serial/ns16550.c |   11 +++++++++++
>  include/ns16550.h        |    3 +++
>  2 files changed, 14 insertions(+), 0 deletions(-)

I dislike this.  This is mostly dead code, enabled for eveybody where
it just increases the memory footprint for no use.

Also I do not understand why it would be needed at all.  We did not
have such a requirement for any system before, so I feel you must be
doing something wrong, or at least very exotic.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Extreme feminine beauty is always disturbing.
	-- Spock, "The Cloud Minders", stardate 5818.4

More information about the U-Boot mailing list