[U-Boot] [PATCH 23/25] SPEAr: Use separate config flags for 3xx and 6xx board files

Amit Virdi amit.virdi at st.com
Mon Mar 12 14:57:50 CET 2012


>> diff --git a/board/spear/common/Makefile b/board/spear/common/Makefile
>> index 11f81e4..48dcfd3 100644
>> --- a/board/spear/common/Makefile
>> +++ b/board/spear/common/Makefile
>> @@ -29,9 +29,14 @@ endif
>>
>>   LIB	= $(obj)lib$(VENDOR).o
>>
>> -COBJS	:= spr_misc.o
>> -SOBJS	:= spr_lowlevel_init.o
>> +COBJS-$(CONFIG_SPEAR3XX) += spr_misc.o
>> +COBJS-$(CONFIG_SPEAR600) += spr_misc.o
>>
>> +SOBJS-$(CONFIG_SPEAR3XX) += spr_lowlevel_init.o
>> +SOBJS-$(CONFIG_SPEAR600) += spr_lowlevel_init.o
>> +
>> +COBJS	:= $(sort $(COBJS-y))
>> +SOBJS	:= $(sort $(SOBJS-y))
>>   SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
>>   OBJS	:= $(addprefix $(obj),$(COBJS))
>>   SOBJS	:= $(addprefix $(obj),$(SOBJS))
>
> I don't really see the benefit of this patch. Could you please explain a bit
> more why this is needed/better?
>

Although it is better this way but the original intention to introduce 
this patch was to add more features which I didn't added in this 
patchset since this patchset aims to provide bug fixes in the already 
existing SPEAr support in u-boot.

Maybe, I can drop this patch in V2.

Regards
Amit Virdi


More information about the U-Boot mailing list