[U-Boot] [PATCH v3 11/28] arm: Use sections header to obtain link symbols

[Simon Glass]

Hi Mike,

On Sat, Mar 10, 2012 at 5:54 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Thursday 08 March 2012 01:39:53 Simon Glass wrote:
>> On Tue, Mar 6, 2012 at 8:17 AM, Mike Frysinger wrote:
>> > On Tuesday 06 March 2012 01:24:21 Simon Glass wrote:
>> >> On Mon, Mar 5, 2012 at 9:03 PM, Mike Frysinger wrote:
>> >> > On Thursday 16 February 2012 09:48:58 Simon Glass wrote:
>> >> >> --- a/board/cm4008/flash.c
>> >> >> +++ b/board/cm4008/flash.c
>> >> >>
>> >> >>  #include <common.h>
>> >> >> +#include <asm-generic/sections.h>
>> >> >
>> >> > arches should provide asm/sections.h, and those are the only headers
>> >> > that should know about asm-generic/sections.h
>> >>
>> >> Similar to my previous comment, but why does each arch have to have
>> >> subtly-different section symbol names? From what I have seen so far
>> >> there can be unified also.
>> >
>> > Blackfin has linker symbols that don't belong in any other port.  this is
>> > also how the kernel does it, and i don't see value in diverging here.
>>
>> OK, so I think I should update the sections.h patch to add
>> asm/sections.h for every arch, initially just with an include to
>> asm-generic/sections.h in each one? Does that sound right?
>
> yep.  unless we want to get really ambitious and extend the generated support
> like the kernel has now -- it automatically generates sub headers for asm/
> redirects to asm-generic/ if the arch hasn't provided one.

I am ambitious enough already :-) I have added these files into the v4
version of the patch.

Regards,
Simon

> -mike