[U-Boot] [PATCH] WIP: fdt: Add serial port controlled by device tree

[Simon Glass]

Hi Mike,

On Tue, Feb 21, 2012 at 7:47 AM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Tuesday 21 February 2012 01:41:21 Simon Glass wrote:
>> --- /dev/null
>> +++ b/common/fdt_decode.c

This whole file was not supposed to be there. I removed it from being
needed but somehow not from the patch, sorry.

>>
>> +static struct fdt_compat compat_types[] = {
>
> const
>
>> +void fdt_decode_uart_calc_divisor(struct fdt_uart *uart)
>> +{
>> +     if (uart->multiplier && uart->baudrate)
>> +             uart->divisor = (uart->clock_freq +
>> +                             (uart->baudrate * (uart->multiplier / 2))) /
>> +                     (uart->multiplier * uart->baudrate);
>> +}
>
> does the multiplier really need to be part of device tree ?
>
>> +int fdt_decode_get_spi_switch(const void *blob, struct fdt_spi_uart
>> *config) +{
>> +     int node, uart_node;
>> +     const u32 *gpio;
>> +
>> +     node = fdt_node_offset_by_compatible(blob, 0,
>> +                                          "nvidia,spi-uart-switch");
>
> what's with the hardcoded SoC names in common code ?
>
>> --- /dev/null
>> +++ b/drivers/serial/serial_fdt.c
>>
>> +void uart_calc_divisor(struct fdt_uart *uart)
>> +{
>> +     if (uart->multiplier && uart->baudrate)
>> +             uart->divisor = (uart->clock_freq +
>> +                             (uart->baudrate * (uart->multiplier / 2))) /
>> +                     (uart->multiplier * uart->baudrate);
>> +}
>
> isn't this exactly the same as fdt_decode_uart_calc_divisor ?

Yes, I copied these functions out.

This patch was just for hanumant but I am going to create a proper
version of this and will post to the list soon.

> -mike

Regards,
Simon