[U-Boot] [PATCH V2] i.MX6: mx6q_sabrelite: add SATA bindings

Stefano Babic sbabic at denx.de
Thu Mar 15 10:58:49 CET 2012


On 15/03/2012 10:34, Liu Hui-R64343 wrote:

> As the comments in the imximage.cfg,
> 
> # set the default clock gate to save power
> DATA 4 0x020c4068 0x00C03F3F
> DATA 4 0x020c406c 0x0030FC03
> DATA 4 0x020c4070 0x0FFFC000
> DATA 4 0x020c4074 0x3FF00000
> DATA 4 0x020c4078 0x00FFF300
> DATA 4 0x020c407c 0x0F0000C3
> DATA 4 0x020c4080 0x000003FF
> 
> This is my intention for the default setting to gate clock as much as possible in
> order to save power. This also means that when other periph added you need
> Turn on the clock explicitly.

Indeed, this is a good idea and respects U-boot principles: enable
something only when it is needed.

> So, my suggestion is:
> - don't change this imximage.cfg,
> - turn on the clock you need in the driver code,

Agree

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the U-Boot mailing list