[U-Boot] [PATCH v4 23/27] Adjust board_f for ppc

Simon Glass sjg at chromium.org
Thu Mar 15 22:25:42 CET 2012


+Graeme

Hi Scott,

On Thu, Mar 15, 2012 at 12:12 PM, Scott Wood <scottwood at freescale.com> wrote:
> On 03/14/2012 09:16 PM, Simon Glass wrote:
>> This adds ppc features to the generic pre-relocation board init.
>
> This is making this file look not very generic.  Can we factor out the
> parts that are actually generic and leave the rest in arch code, rather
> than create a mess of ifdefs?

Yes that is the plan - Graeme is working on an initcall setup which
will make this really easy. For now we have #ifdefs. Bear in mind that
most of these were already there in arch/powerpc/lib/board.c.

One other point - one of the reasons that this patch adds so much code
is that PPC supports more features than other architectures. In fact I
hope that we can make most of those features generic, so that we can
remove the PPC #ifdefs and support them for all architectures.

Regards,
Simon

>
> -Scott
>


More information about the U-Boot mailing list