[U-Boot] [PATCH v2] kirkwood: add support for Cloud Engines Pogoplug E02
David Purdy
david.c.purdy at gmail.com
Thu Mar 15 22:57:19 CET 2012
Hi Prafulla,
Just discovered one important thing to let you know regarding the v3 patch
that I'll send to you later...
I misinterpreted a question you asked regarding "100% clone of existing
files in the repo".
For instance,
boards/Seagate/dockstar/kwbimage.cfg and
boards/cloudengines/pogoplug_e02/kwbimage.cfg
and pretty much everything else in boards/Seagate/dockstar/ and
boards/cloudengines/pogoplug_e02/ differ significantly. There are some
similarities w/ many sections, but nevertheless numerous differences. RAM,
NAND and GPIO/LED setup all differ, as far as the hardware.
So, nothing is 100% clone of existing file in the repo.
I have gone ahead and fixed the ordering/alphabetization in boards.cfg, and
will supply a URL/link to the pogoplug_e02 board in the description.
thanks, regards,
Dave
On Thu, Mar 15, 2012 at 3:12 AM, Prafulla Wadaskar <prafulla at marvell.com>wrote:
>
>
> > -----Original Message-----
> > From: David Purdy [mailto:david.c.purdy at gmail.com]
> > Sent: 14 March 2012 23:32
> > To: Prafulla Wadaskar
> > Cc: u-boot at lists.denx.de; albert.u.boot at aribaud.net
> > Subject: Re: [PATCH v2] kirkwood: add support for Cloud Engines
> > Pogoplug E02
> >
> > Thank you Prafulla,
> >
> > I supplied 4 responses and some questions ...
> >
> > On Wed, Mar 14, 2012 at 9:23 AM, Prafulla Wadaskar
> > <prafulla at marvell.com> wrote:
> > >
> > >
> > >> -----Original Message-----
> > >> From: David C. Purdy [mailto:david.c.purdy at gmail.com]
> > >> Sent: 14 March 2012 05:47
> > >> To: u-boot at lists.denx.de
> > >> Cc: Prafulla Wadaskar; albert.u.boot at aribaud.net
> > >> Subject: [PATCH v2] kirkwood: add support for Cloud Engines
> > Pogoplug
> > >> E02
> > >>
> > >> [PATCH v2] add support for Cloud Engines Pogoplug E02
> > >>
> > >> This patch adds support for Cloud Engines Pogoplug E02.
> > >
> >
> > 1.
> > > May you please add here a pointer of the board information here?
> >
> > Will this suffice for pointer regarding board information:
> >
> > http://archlinuxarm.org/platforms/armv5/pogoplug-v2-pinkgray
> >
> > ... or do you need something more specific? (not sure what level of
> > detail you wish)
>
> I think this is enough, please add this link for your next patch version
> in the patch description.
>
> >
> > >
> >
> >
> > 2.
> > > May you please explain how different this board is if compared to
> > Sheevaplug, Guruplug, DreamPlug ?
> >
> > Sheevaplug - 512MB NAND, 512MB RAM, USB, SD card slot & other
> > differences
> > Guruplug - 512MB NAND, 512MB RAM, USB, SATA & other
> > differences
> > Dreamplug - 2MB NAND, 512MB RAM, Audio, USB, eSATA & other
> > differences
> > Pogoplug E02 - 128MB NAND, 256MB RAM, USB
> >
> >
> > ... actually it is probably closest to the Seagate Dockstar (which is
> > supported in U-Boot stable since 2010.12 IIRC), but there are enough
> > differences that the Dockstar's u-boot binary will not work correctly
> > in the Pogoplug E02.
>
> So in this case, can you use boards/Seagate/dockstar/kwbimage.cfg instead
> of creating one more similar file?
>
> You rest of code will remain as it is.
>
> >
> > >>
> > >> Signed-off-by: David Purdy <david.c.purdy at gmail.com>
> > >> Cc: prafulla at marvell.com
> > >> Cc: albert.u.boot at aribaud.net
> > >> ---
> > >> Changes for v2:
> > >> - added MAINTAINERS info for pogoplug_e02
> > >> - fixed format to ensure capture of all files in path
> > >>
> > >> MAINTAINERS | 4 +
> > >> board/cloudengines/pogoplug_e02/Makefile | 49 +++++++
> > >> board/cloudengines/pogoplug_e02/kwbimage.cfg | 165
> > >
> >
> > 3.
> > > Is this file 100% clone of existing file on the repository? Or you
> > have modified it further for your board, if not, you can reuse the old
> > one.
> >
> > I may make some modest/minor modifications to it in the future.
> > Perhaps in the GPIO section.
> >
> > For that reason I'd like the pogoE02 to have its own.
> > Does that sound OK?
>
> Intention here is to avoid duplicate code, the framework is created to
> support this, if kwbimage.cfg can be reused from dockstart project, we can
> add little code to support your board, in future if there are expansion and
> updates you can have your own.
>
> >
> >
> > >
> > >> ++++++++++++++++++++++++
> > >> board/cloudengines/pogoplug_e02/pogoplug_e02.c | 148
> > >> +++++++++++++++++++++
> > >> board/cloudengines/pogoplug_e02/pogoplug_e02.h | 46 +++++++
> > >> boards.cfg | 1 +
> > >> include/configs/pogoplug_e02.h | 123
> > >> ++++++++++++++++++
> > >> 7 files changed, 536 insertions(+), 0 deletions(-)
> > >> create mode 100644 board/cloudengines/pogoplug_e02/Makefile
> > >> create mode 100644 board/cloudengines/pogoplug_e02/kwbimage.cfg
> > >> create mode 100644 board/cloudengines/pogoplug_e02/pogoplug_e02.c
> > >> create mode 100644 board/cloudengines/pogoplug_e02/pogoplug_e02.h
> > >> create mode 100644 include/configs/pogoplug_e02.h
> > >>
> > >> diff --git a/MAINTAINERS b/MAINTAINERS
> > >> index 46f63a0..ae65ff3 100644
> > >> --- a/MAINTAINERS
> > >> +++ b/MAINTAINERS
> > >> @@ -793,6 +793,10 @@ Stelian Pop <stelian at popies.net>
> > >> at91sam9263ek ARM926EJS (AT91SAM9263 SoC)
> > >> at91sam9rlek ARM926EJS (AT91SAM9RL SoC)
> > >>
> > >> +Dave Purdy <david.c.purdy at gmail.com>
> > >> +
> > >> + pogoplug_e02 ARM926EJS (Kirkwood SoC)
> > >> +
> > >
> >
> >
> > 3.
> > > Please maintain the order here?
> > >
> > >> Thierry Reding <thierry.reding at avionic-design.de>
> > >>
> > >> plutux Tegra2 (ARM7 & A9 Dual Core)
> >
> > I'm not at all sure I understand you there. Alphabetically: Pop,
> > Purdy, Reding...
> > all in the ARM section..
>
> I think you are right here, the MAINTAINERs file structure is bit
> confusing at some places, mostly order is maintained by second name and you
> are right here.
>
> >
> >
> >
> > >> +#endif /* __POGOPLUG_E02_H */
> > >> diff --git a/boards.cfg b/boards.cfg
> > >> index 28cc345..3cdf17e 100644
> > >> --- a/boards.cfg
> > >> +++ b/boards.cfg
> > >> @@ -154,6 +154,7 @@ openrd_ultimate arm
> > arm926ejs
> > >> openrd Marvell
> > >> rd6281a arm arm926ejs -
> > >> Marvell kirkwood
> > >> sheevaplug arm arm926ejs -
> > >> Marvell kirkwood
> > >> dockstar arm arm926ejs -
> > >> Seagate kirkwood
> > >> +pogoplug_e02 arm arm926ejs -
> > >> cloudengines Kirkwood
> > >
> >
> > 4.
> > > Please maintain an order here too.
> > >
> > Yes, I see. If I understand you, this would become:
> >
> > calimain arm arm926ejs calimain
> > omicron davinci
> > pogoplug_e02 arm arm926ejs -
> > cloudengines kirkwood
> > dns325 arm arm926ejs -
> > d-link Kirkwood
>
> Yes, that's correct.
>
> Regards..
> Prafulla . ..
>
More information about the U-Boot
mailing list