[U-Boot] [PATCH v3] kirkwood: add support for Cloud Engines Pogoplug E02

Wolfgang Denk wd at denx.de
Fri Mar 16 08:41:02 CET 2012

Dear "David C. Purdy",

In message <alpine.DEB.2.00.1203152035020.6790 at bitbaker64> you wrote:
> This patch adds support for Cloud Engines Pogoplug E02.
> Information regarding the CE Pogoplug E02 board can be found at:
> http://archlinuxarm.org/platforms/armv5/pogoplug-v2-pinkgray
> Signed-off-by: David Purdy <david.c.purdy at gmail.com>
> Cc: prafulla at marvell.com
> Cc: albert.u.boot at aribaud.net

Checpatch reports a large number of trailing white space errors.
Please fix, and make sure to run checkpatch before resubmitting.

> +	if (miiphy_read(name, 0xEE, 0xEE, (u16 *) &devadr)) {
> +		printf("Err..(%s) could not read PHY dev address\n", 
> __func__);

Your patch is line-wrapped and cannot be used.  Please fix your mailer
setup.  Ideally use git-send-email to dubmit patches.

> +#define POGOPLUG_E02_OE_VAL_HIGH		(0)

Don't use parens around simple arguments.

> +/*
> + * max 4k env size is enough, but in case of nand
> + * it has to be rounded to sector size
> + */

I think this is not correct.

> +#define CONFIG_ENV_SIZE			0x20000	/* 128k */

If it was correct, you should use CONFIG_ENV_SECT_SIZE instead of a
hard-wired constant which might be wrong.

> +#define CONFIG_ENV_ADDR			0x60000
> +#define CONFIG_ENV_OFFSET		0x60000	/* env starts here */

Using both ADDR and OFFSET is redundant at best.  Drop one.

> +	"mtdparts=mtdparts=orion_nand:1M(u-boot),4M(uImage)," \
> +	"mtdids=nand0=orion_nand\0"\

Orion ?

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The universe, they said, depended for its operation on the balance of
four forces which they identified as charm,  persuasion,  uncertainty
and bloody-mindedness.      -- Terry Pratchett, "The Light Fantastic"

More information about the U-Boot mailing list