[U-Boot] [PATCH v2] add new board nas62x0

Wolfgang Denk wd at denx.de
Sun Mar 18 11:04:28 CET 2012

Dear Luka Perkov,

In message <20120317234054.GA21334 at w500.lan> you wrote:
> Add support for new boards RaidSonic ICY BOX NAS6210 and NAS6220 boards.

Just a tiny detail...

> +/*
> + * Version number information
> + */
> +#ifdef CONFIG_BOARD_IS_IB_NAS6210
> +# define CONFIG_IDENT_STRING	" RaidSonic ICY BOX IB-NAS6210"

For robustness, this should rather be

	#elif defined(CONFIG_BOARD_IS_IB_NAS6220)

[and for consistency, you then may want to reqrite the #if above as

	#if defined(CONFIG_BOARD_IS_IB_NAS6210)



Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I often quote myself; it adds spice to my conversation.  - G. B. Shaw

More information about the U-Boot mailing list