[U-Boot] [PATCH v3] video: cfb_console: Make the software cursor non-destructive

Wolfgang Denk wd at denx.de
Sun Mar 18 19:38:57 CET 2012


Dear Anatolij Gustschin,

In message <20111205220742.18ed6e2f at wker> you wrote:
> On Thu,  1 Dec 2011 00:50:50 +0100
> Anatolij Gustschin <agust at denx.de> wrote:
> 
> > From: Gabe Black <gabeblack at chromium.org>
> > 
> > When printing the string "\r\n" to the framebuffer console, the first
> > character of the current line was being replaced with a space. The "boot"
> > prompt would become the "oot" prompt. This change makes the cursor
> > non-destructive so that no matter where it goes on its way to where it's
> > supposed to be, the end result is that the cursor is where it's supposed to
> > be with the other text preserved.
> > 
> > Signed-off-by: Gabe Black <gabeblack at chromium.org>
> > Acked-by: Mike Frysinger <vapier at gentoo.org>
> > Signed-off-by: Anatolij Gustschin <agust at denx.de>
> > ---
> > Changes in v3:
> > - fixed checkpatch errors
> > - slightly modified subject line
> > - fixed cursor position if video logo is used
> > 
> > Changes in v2:
> > - Tidy up commit message wording.
> > - Undo change to documenting comment.
> > - Undo minor whitespace tweak.
> > - Consolidate CONFIG_CONSOLE_CURSOR and CONFIG_VIDEO_SW_CURSOR.
> > - Get rid of a space between video_invertchar and its (.
> > 
> >  drivers/video/cfb_console.c |  109 +++++++++++++++++++++----------------------
> >  1 files changed, 53 insertions(+), 56 deletions(-)
> 
> Applied to u-boot-video/master. Thanks!

It appears this has not made it into mainline yet.

Is it still queued in your repo?  Do you intend to send a pull request
any time soon?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Why is an average signature file longer than an average Perl script??


More information about the U-Boot mailing list