[U-Boot] [PATCH] mxs_spi: Return proper timeout error
Marek Vasut
marek.vasut at gmail.com
Mon Mar 19 04:40:17 CET 2012
Dear Fabio Estevam,
> Instead of returning -1, it is preferred to return -ETIMEDOUT in case of
> timeouts.
>
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> ---
> drivers/spi/mxs_spi.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/spi/mxs_spi.c b/drivers/spi/mxs_spi.c
> index adb9ca8..4e6f14e 100644
> --- a/drivers/spi/mxs_spi.c
> +++ b/drivers/spi/mxs_spi.c
> @@ -162,7 +162,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int
> bitlen, if (mx28_wait_mask_set(&ssp_regs->hw_ssp_ctrl0_reg,
> SSP_CTRL0_RUN, MXS_SPI_MAX_TIMEOUT)) {
> printf("MXS SPI: Timeout waiting for start\n");
> - return -1;
> + return -ETIMEDOUT;
> }
>
> if (tx)
> @@ -174,7 +174,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int
> bitlen, if (mx28_wait_mask_clr(&ssp_regs->hw_ssp_status_reg,
> SSP_STATUS_FIFO_EMPTY, MXS_SPI_MAX_TIMEOUT)) {
> printf("MXS SPI: Timeout waiting for data\n");
> - return -1;
> + return -ETIMEDOUT;
> }
>
> *rx = readl(&ssp_regs->hw_ssp_data);
> @@ -184,7 +184,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int
> bitlen, if (mx28_wait_mask_clr(&ssp_regs->hw_ssp_ctrl0_reg,
> SSP_CTRL0_RUN, MXS_SPI_MAX_TIMEOUT)) {
> printf("MXS SPI: Timeout waiting for finish\n");
> - return -1;
> + return -ETIMEDOUT;
> }
> }
Acked-by: Marek Vasut <marex at denx.de>
Best regards,
Marek Vasut
More information about the U-Boot
mailing list