[U-Boot] [PATCH v4 12/15] bootstage: Replace show_boot_progress/error() with bootstage_...()

Wolfgang Denk wd at denx.de
Mon Mar 19 09:34:38 CET 2012

Dear Simon Glass,

In message <1329177081-29496-13-git-send-email-sjg at chromium.org> you wrote:
> These calls should not be made directly any more, since bootstage
> will call the show_boot_...() functions as needed.
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> Changes in v4:
> - Adjust bootstage.h header to fix build warnings (bisect problem)

Actually not all bisect issues have been fixed.  Commit
5dc8871 bootstage: Convert progress numbers 1-9 into enums
breaks build with this error:

image.c: In function 'boot_get_ramdisk':
image.c:898: error: 'BOOTSTAGE_ID_LOAD_RAMDISK' undeclared (first use in this function)
image.c:898: error: (Each undeclared identifier is reported only once
image.c:898: error: for each function it appears in.)

Also, the v4 12/15 commit breaks the ETX094 board when building with
ELDK 4.2 due to grown code size:

Before (v2011.12-511-g5ff5539)

   text    data     bss     dec     hex filename
  17752    1026    2585   21363    5373 /work/wd/tmp-ppc/net/libnet.o

After (v2011.12-512-g77060e):

   text    data     bss     dec     hex filename
  17788    1026    2585   21399    5397 /work/wd/tmp-ppc/net/libnet.o

Yes, the increase is small, but the linker map for this board is
carefully crafted ;-)

I think I can fix this, though.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Wenn das dann in die Hose geht, nehme ich es auf meine Kappe.
                                         -- Rudi Völler, 15. Nov 2003

More information about the U-Boot mailing list