[U-Boot] [PATCH V2] i.MX28: Drop __naked function from spl_mem_init

Stefano Babic sbabic at denx.de
Tue Mar 20 10:21:35 CET 2012


On 20/03/2012 10:09, Marek Vasut wrote:

>> In which way is this self-modifying code? I don't think so.
> 
> Because it rewrites piece of RAM, which is then called in the Data abort 
> context.

Exactly

>>
>> My understanding is that to avoid the warning we can either use this
>> "pre-compiled constant instruction" trick, or we would have to create
>> a new assembler source file for this single instruction function.
> 
> Or put it into start.S
> 
>>
>> When Marek and I discussed this, the constant seemed to be the
>> simplest approach (not the nicest, though).
> 
> Ack

Ok - Marek, I think we have clarified why we need it and why we need to
make dirty things..you do not need to change, I will apply the patch as
it is to u-boot-imx.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the U-Boot mailing list