[U-Boot] [PATCH 2/5] Add board_panic_no_console() to deal with early critical errors

Stephen Warren swarren at wwwdotorg.org
Wed Mar 21 01:34:56 CET 2012


On 03/20/2012 05:22 PM, Simon Glass wrote:
> On Tue, Mar 20, 2012 at 3:26 PM, Graeme Russ <graeme.russ at gmail.com> wrote:
...
>> OK, so what about in panic():
>>  - If gd->have_console is not set:
>>    o call the board specific setup_panic_uarts()
>>    o call print_pre_console_buffer() passing panic_putc()
>>    o call panic_putc() for all characters in str[]
>>  - If gd->have_console is set:
>>    o call putc() for all characters in str[]
>>
>> setup_panic_uarts() and panic_putc() are overriden in the board files
> 
> I think this is where we got to last time.
> 
> The act of calling this pre-console panic function is destructive - it
> may hang the board and output data to UARTs.

Why would it hang? Well, I assume you're talking about hanging before
actually emitting the panic text, rather than looping afterwards as a
deliberate choice. I'd consider an accidental hang that prevented the
message being seen as a bug.


More information about the U-Boot mailing list