[U-Boot] [PATCH 3/5] tegra: Export the UART setup function for use by boards

Wolfgang Denk wd at denx.de
Wed Mar 21 10:04:54 CET 2012

Dear Simon Glass,

In message <1332188824-5447-3-git-send-email-sjg at chromium.org> you wrote:
> Allow boards to call the tegra_setup_uarts() function so that they
> can set up UARTs on demand. The UART selection enum is moved into the
> board.h header file so that boards can use this for pre-console panic.

I dislike this.  This is broken by design.

Even if the could would work today, it would break as soon as we
switch to using a clean device model.

Don't do that, you are opening a can of worms that cannot be closed
easily, and you don't do yourself a favour with it.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Committee, n.:  A group of men who individually can do nothing but as
a group decide that nothing can be done.                 - Fred Allen

More information about the U-Boot mailing list