[U-Boot] [PATCH v4] add new board nas62x0

[Prafulla Wadaskar]

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-
> bounces at lists.denx.de] On Behalf Of Igor Grinberg
> Sent: 21 March 2012 12:25
> To: u-boot at lists.denx.de; dreagle at doukki.net; marek.vasut at gmail.com;
> gmbnomis at gmail.com
> Subject: Re: [U-Boot] [PATCH v4] add new board nas62x0
> 
> Hi Luka,
> 
> On 03/21/12 02:53, Luka Perkov wrote:
> > Add support for new boards RaidSonic ICY BOX NAS6210 and NAS6220.
> >
> > Only difference between boards is number of SATA ports.
> >
> > Signed-off-by: Luka Perkov <uboot at lukaperkov.net>
> > Signed-off-by: Gerald Kerma <dreagle at doukki.net>
> > ---
> >
> > Changes from version v3:
> >
> >  * don't use utf8 for Geralds name
> >  * don't mix upper/lower case in kwbimage.cfg
> >  * fix prompt
> >
> > Found problems that should be looked at (this is not related with
> adding
> > support for this board):
> >
> >  * IB62x0_OE_LOW and IB62x0_OE_HIGH issue
> >  * CONFIG_SKIP_LOWLEVEL_INIT issue
> >
> > In separate patch I'll resend fix for CONFIG_SKIP_LOWLEVEL_INIT.
> >
> >
> >  MAINTAINERS                       |    4 +
> >  board/Marvell/ib62x0/Makefile     |   51 +++++++++++
> >  board/Marvell/ib62x0/ib62x0.c     |  114 ++++++++++++++++++++++++
> >  board/Marvell/ib62x0/ib62x0.h     |   41 +++++++++
> >  board/Marvell/ib62x0/kwbimage.cfg |  167
> +++++++++++++++++++++++++++++++++++
> >  boards.cfg                        |    2 +
> >  include/configs/ib62x0.h          |  176
> +++++++++++++++++++++++++++++++++++++
> >  7 files changed, 555 insertions(+)
> 
> [...]
> 
> > diff --git a/board/Marvell/ib62x0/Makefile
> b/board/Marvell/ib62x0/Makefile
> > new file mode 100644
> > index 0000000..3d82f27
> > --- /dev/null
> > +++ b/board/Marvell/ib62x0/Makefile
> > @@ -0,0 +1,51 @@
> > +# You should have received a copy of the GNU General Public License
> > +# along with this program; if not, write to the Free Software
> > +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> > +# MA 02110-1301 USA
> 
> It is better to remove the postal address, as it is subject to change.
> Please, check all files you add.

I think specifying email address or/and website is more meaning full.
 
> 
> > +clean:
> > +	rm -f $(SOBJS) $(OBJS)
> > +
> > +distclean:	clean
> > +	rm -f $(LIB) core *.bak .depend
> 
> clean and distclean have no effect here and should be removed.
> 
> [...]
> 
> > diff --git a/board/Marvell/ib62x0/ib62x0.c
> b/board/Marvell/ib62x0/ib62x0.c
> > new file mode 100644
> > index 0000000..e6853e7
> > --- /dev/null
> > +++ b/board/Marvell/ib62x0/ib62x0.c
> 
> [...]
> 
> > +int board_init(void)
> > +{
> > +	/*
> > +	 * arch number of board
> > +	 */
> > +	gd->bd->bi_arch_number = MACH_TYPE_NAS6210;
> 
> This should be handled in a generic way:
> #define CONFIG_MACH_TYPE MACH_TYPE_NAS6210
> in your board config file.

Is this board support already available in Linux kernel ?

Regards..
Prafulla . . .