[U-Boot] [PATCH v2] add new board nas62x0

[Prafulla Wadaskar]

> -----Original Message-----
> From: Marek Vasut [mailto:marex at denx.de]
> Sent: 21 March 2012 16:27
> To: Prafulla Wadaskar
> Cc: Luka Perkov; u-boot at lists.denx.de; dreagle at doukki.net; Wolfgang
> Denk
> Subject: Re: [U-Boot] [PATCH v2] add new board nas62x0
> 
> Dear Prafulla Wadaskar,
> 
> > > -----Original Message-----
> > > From: Marek Vasut [mailto:marex at denx.de]
> > > Sent: 21 March 2012 15:33
> > > To: Prafulla Wadaskar
> > > Cc: Luka Perkov; u-boot at lists.denx.de; dreagle at doukki.net;
> Wolfgang
> > > Denk
> > > Subject: Re: [U-Boot] [PATCH v2] add new board nas62x0
> > >
> > > Dear Prafulla Wadaskar,
> >
> > ...snip...
> >
> > > > Hi Luka
> > > >
> > > > #1: Defining these values as 0xffffffff, indicates that all
> GPIOs
> > >
> > > are
> > >
> > > > configured high by default. so this configuration solely depends
> > >
> > > upon your
> > >
> > > > board requirement.
> > > >
> > > > #2: on kirkwood, you should define CONFIG_SKIP_LOWLEVEL_INIT
> since
> > > > lowlevel_init is not needed on Kirkwood platforms. (ref:
> > > > doc/README.kwbimage)
> > >
> > > Prafulla, you're then missing the fiddling with CPSR bits, which
> might
> > > be quite
> > > necessary.
> >
> > Hi Marek.
> > May be, may you please explain these bits? Or any pointers? Can't
> these be
> > addressed in kwimage.cfg?
> 
> I have no idea, I'm no kirkwood expert. And about these bits, check
> start.S,
> what it does with them.

Hi Marek,

I have checked arc/arm/cpu/arm926ejs/start.S, and I didn't find any issue, lowlevel_init will be called from cpu_init_crit which should be okay, there is cache init related code in it, if that can be a problem then it should be kept out.
And on Kirkwood, internal bootloader does the job of lowlevel_init prior to start uboot execution.

Regards..
Prafulla . . .