[U-Boot] [PATCH 2/2] configs: imx: Use CONFIG_SF_DEFAULT_CS

Marek Vasut marex at denx.de
Fri Mar 23 10:18:15 CET 2012


Dear Stefano Babic,

> On 23/03/2012 09:39, Marek Vasut wrote:
> > Dear Fabio Estevam,
> > 
> >> CONFIG_SPI_FLASH_CS is not used anywhere.
> >> 
> >> Use CONFIG_SF_DEFAULT_CS instead.
> >> 
> >> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> >> ---
> >> 
> >>  include/configs/efikamx.h |    2 +-
> >>  include/configs/m28evk.h  |    2 +-
> >>  include/configs/vision2.h |    2 +-
> >>  3 files changed, 3 insertions(+), 3 deletions(-)
> >> 
> >> diff --git a/include/configs/efikamx.h b/include/configs/efikamx.h
> >> index af542fa..120055f 100644
> >> --- a/include/configs/efikamx.h
> >> +++ b/include/configs/efikamx.h
> >> @@ -113,7 +113,7 @@
> >> 
> >>  #define CONFIG_SPI_FLASH
> >>  #define CONFIG_SPI_FLASH_SST
> >> 
> >> -#define CONFIG_SPI_FLASH_CS		(1 | 121 << 8)
> >> +#define CONFIG_SF_DEFAULT_CS		(1 | 121 << 8)
> >> 
> >>  #define CONFIG_SF_DEFAULT_MODE		(SPI_MODE_0)
> >>  #define CONFIG_SF_DEFAULT_SPEED		25000000
> >> 
> >> diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
> >> index 4d59153..4b97c71 100644
> >> --- a/include/configs/m28evk.h
> >> +++ b/include/configs/m28evk.h
> >> @@ -252,7 +252,7 @@
> >> 
> >>  #ifdef	CONFIG_CMD_SF
> >>  #define	CONFIG_SPI_FLASH
> >>  #define	CONFIG_SPI_FLASH_STMICRO
> >> 
> >> -#define	CONFIG_SPI_FLASH_CS		2
> >> +#define	CONFIG_SF_DEFAULT_CS		2
> > 
> > are you sure about this? Are you sure this does the same thing?
> 
> Are we sure that CONFIG_SPI_FLASH_CS has still a meaning ? It seems to
> me that SPI flash uses now CONFIG_SF_DEFAULT_CS, and we should exchange
> other boards exactly as Fabio does for mx28evk. Is there still code
> using CONFIG_SPI_FLASH_CS ?

No, that's why I'm asking. And I see no use of CONFIG_SPI_FLASH_CS. All right 
then:

Acked-by: Marek Vasut <marex at denx.de>

> 
> Best regards,
> Stefano Babic

Best regards,
Marek Vasut


More information about the U-Boot mailing list