[U-Boot] [PATCH 08/25] SPEAr: Add configuration options for spear3xx and spear6xx boards

[Stefan Roese]

Hi Amit,

On Monday 26 March 2012 14:10:04 Amit Virdi wrote:
> >> +++ b/board/spear/spear300/config.mk
> >> @@ -25,15 +25,4 @@
> >> 
> >>   CONFIG_SYS_TEXT_BASE = 0x00700000
> >> 
> >> -ALL-y += $(obj)u-boot.img
> >> -
> >> -# Environment variables in NAND
> >> -ifeq ($(ENV),NAND)
> >> -PLATFORM_RELFLAGS += -DCONFIG_ENV_IS_IN_NAND
> >> -else
> >> -PLATFORM_RELFLAGS += -DCONFIG_ENV_IS_IN_FLASH
> >> -endif
> >> -
> >> -ifeq ($(CONSOLE),USB)
> >> -PLATFORM_RELFLAGS += -DCONFIG_SPEAR_USBTTY
> >> -endif
> >> +ALL += $(obj)u-boot.img
> > 
> > Can't you just remove this config.mk file completely?
> > CONFIG_SYS_TEXT_BASE can be moved to the config header instead. What
> > else is this file needed for?
> 
> Could you please explain which config header you are referring to here?
> Do you mean include/configs/spear..... ?

Yes.

> For SPEAr310 and SPEAr320, config.mk is needed to make image (by
> specifying FLASH=PNOR during compile time) that can access CFI compliant
> PNOR flash.

In the example above (spear300), only CONFIG_SYS_TEXT_BASE is left in 
config.mk. This can be moved to the config header (include/configs/spear-xxx-
h).

You should be able to move the other remaining options (PNOR...) to 
boards.cfg. Or is this not possible?

Thanks,
Stefan