[U-Boot] [PATCH] cmd_nand: Fix possible uninited max_size variable

Scott Wood scottwood at freescale.com
Mon Mar 26 18:17:30 CEST 2012


On 03/23/2012 06:27 PM, Marek Vasut wrote:
> GCC 4.7 error:
> cmd_nand.c: In function ‘arg_off_size’:
> cmd_nand.c:216:5: warning: ‘maxsize’ may be used uninitialized in this function [-Wmaybe-uninitialized]

Yay, with a new compiler comes a new batch of false positives. :-P

I'm surprised it complained at line 216 but not line 208.

> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Scott Wood <scottwood at freescale.com>
> ---
>  common/cmd_nand.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/common/cmd_nand.c b/common/cmd_nand.c
> index 035a6f6..b015d11 100644
> --- a/common/cmd_nand.c
> +++ b/common/cmd_nand.c
> @@ -191,7 +191,7 @@ static int arg_off_size(int argc, char *const argv[], int *idx,
>  			loff_t *off, loff_t *size)
>  {
>  	int ret;
> -	loff_t maxsize;
> +	loff_t maxsize = 0;
>  
>  	if (argc == 0) {
>  		*off = 0;

I'll apply for next merge window.

-Scott



More information about the U-Boot mailing list