[U-Boot] [PATCH v2] spi/kirkwood: add weak functions board_spi_bus_claim/release

Valentin Longchamp valentin.longchamp at keymile.com
Tue Mar 27 15:27:50 CEST 2012


Prafulla,

On 03/26/2012 11:58 AM, Valentin Longchamp wrote:
> Some kirkwood based boards may need to implement such function due to
> some HW designs.

I see no feedback from your side on this patch. I think you should go through
the marvell tree:

- the spi_claim/release_bus function are already implemented in the SPI subsystem
- this patch touches only a kirkwood driver
- there is no spi u-boot tree from what I see

Please keep me up to date about the status of this patch

Regards

Valentin

> 
> Signed-off-by: Valentin Longchamp <valentin.longchamp at keymile.com>
> cc: Gerlando Falauto <gerlando.falauto at keymile.com>
> cc: Prafulla Wadaskar <prafulla at marvell.com>
> cc: Holger Brunck <holger.brunck at keymile.com>
> ---
>  drivers/spi/kirkwood_spi.c |   12 +++++++++++-
>  1 files changed, 11 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
> index db8ba8b..058dae2 100644
> --- a/drivers/spi/kirkwood_spi.c
> +++ b/drivers/spi/kirkwood_spi.c
> @@ -86,13 +86,23 @@ void spi_free_slave(struct spi_slave *slave)
>  	free(slave);
>  }
>  
> -int spi_claim_bus(struct spi_slave *slave)
> +__attribute__((weak)) int board_spi_claim_bus(struct spi_slave *slave)
>  {
>  	return 0;
>  }
>  
> +int spi_claim_bus(struct spi_slave *slave)
> +{
> +	return board_spi_claim_bus(slave);
> +}
> +
> +__attribute__((weak)) void board_spi_release_bus(struct spi_slave *slave)
> +{
> +}
> +
>  void spi_release_bus(struct spi_slave *slave)
>  {
> +	board_spi_release_bus(slave);
>  }
>  
>  #ifndef CONFIG_SPI_CS_IS_VALID


More information about the U-Boot mailing list