[U-Boot] [PATCH V2] fs/fat: align disk buffers on cache line to enable DMA and cache

Dirk Behme dirk.behme at googlemail.com
Tue Mar 27 18:28:21 CEST 2012


On 27.03.2012 16:20, Anatolij Gustschin wrote:
> Hello Dirk,
>
> On Sat, 24 Mar 2012 08:18:38 +0100
> Dirk Behme<dirk.behme at googlemail.com>  wrote:
>
>> On 13.03.2012 02:24, Eric Nelson wrote:
>>> On 03/04/2012 02:46 PM, Eric Nelson wrote:
>>>> Signed-off-by: Eric Nelson<eric.nelson at boundarydevices.com>
>>>> Acked-by: Mike Frysinger<vapier at gentoo.org>
>>>> ---
>>>> fs/fat/fat.c | 14 ++++++++------
>>>> 1 files changed, 8 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/fs/fat/fat.c b/fs/fat/fat.c
>>>> index 1f95eb4..f3c48bb 100644
>>>> --- a/fs/fat/fat.c
>>>> +++ b/fs/fat/fat.c
>>>> @@ -31,6 +31,8 @@
>>>> #include<fat.h>
>>>> #include<asm/byteorder.h>
>>>> #include<part.h>
>>>> +#include<malloc.h>
>>>> +#include<linux/compiler.h>
>>>>
>>>> /*
>>>> * Convert a string to lowercase.
>>>> @@ -62,7 +64,7 @@ static int disk_read(__u32 block, __u32 nr_blocks,
>>>> void *buf)
>>>>
>>>> int fat_register_device (block_dev_desc_t * dev_desc, int part_no)
>>>> {
>>>> - unsigned char buffer[dev_desc->blksz];
>>>> + ALLOC_CACHE_ALIGN_BUFFER(unsigned char, buffer, dev_desc->blksz);
>>>   >  <snip>
>>>
>>> Hi Wolfgang,
>>>
>>> Have you had a chance to review this patch? Is there another
>>> maintainer for fs/fat?
>>>
>>> Please let me know if you need this updated.
>>>
>>> There's another patch that was acked by Mike but is otherwise
>>> lingering here:
>>>
>>> http://lists.denx.de/pipermail/u-boot/2012-March/119309.html
>>>
>>> Both of these are needed before enabling the data cache on i.MX6 when
>>> using
>>> the FAT filesystem.
>>
>> Anybody likes to comment/apply this patch?
>
> Both, this patch and the patch referenced by the above link were
> submitted when the merge window was closed. So, the patches will
> probably be applied to next when rc1 is out, unless Wolfgang
> decides to accept them for coming release.

Ok, thanks!

Do we have a -next branch for stuff like this, then?

Best regards

dirk



More information about the U-Boot mailing list