[U-Boot] [PATCH v2] lsxl: add support for lschlv2 and lsxhl

Michael Walle michael at walle.cc
Thu Mar 29 16:39:18 CEST 2012


Am Donnerstag 29 März 2012, 16:24:23 schrieb Prafulla Wadaskar:
> > -----Original Message-----
> > From: Michael Walle [mailto:michael at walle.cc]
> > Sent: 29 March 2012 18:08
> > To: Prafulla Wadaskar
> > Cc: u-boot at lists.denx.de
> > Subject: Re: [PATCH v2] lsxl: add support for lschlv2 and lsxhl
> > 
> > Am Dienstag 27 März 2012, 09:27:49 schrieb Prafulla Wadaskar:
> > > > # diff --git a/board/buffalo/lsxl/config.mk
> > > > b/board/buffalo/lsxl/config.mk new file mode 100644
> > > > index 0000000..062554b
> > > > --- /dev/null
> > > > +++ b/board/buffalo/lsxl/config.mk
> > > > @@ -0,0 +1 @@
> > > > +ALL-y += $(obj)u-boot.kwb
> > > 
> > > Pls remove this file
> > 
> > Is there another way to build the u-boot.kwb binary by default?
> > 
> > The main Makefile states:
> > # Always append ALL so that arch config.mk's can add custom ones
> > 
> > and theres a rule for $(obj)u-boot.kwb.
> 
> Just pass u-boot.kwm to the make, will do the needful, if this satisfies
> the goal of generating u-boot.kwb, then why to add one file to the source
> code?
 - this won't work easily for out-of-tree builds, will it? because you have to 
pass $(obj)u-boot.kwb to make and $(obj) is $O which is specified by the user, 
so he has to specify it twice
 - i'm only interested in the u-boot.kwb, why shouldn't it be generated by 
default?
 - i can't build it with a sinlge make call. Eg. atm i'm doing
    make -j3 -C ../u-boot O=`pwd` CROSS_COMPILE=arm-linux-gnueabi- lschlv2
   otherwise i have to do
    make -j3 -C ../u-boot O=`pwd` CROSS_COMPILE=arm-linux-gnueabi- lschlv2
    make -j3 -C ../u-boot O=`pwd` CROSS_COMPILE=arm-linux-gnueabi- \
       `pwd`/u-boot.kwb

Overall, it will greatly simplify thinks :)

-- 
Michael


More information about the U-Boot mailing list