[U-Boot] [PATCH] MIPS: fix endianess handling

Marek Vasut marek.vasut at gmail.com
Sat Mar 31 22:54:27 CEST 2012


Dear Daniel Schwierzeck,

> On 12/04/2011 04:08 PM, Wolfgang Denk wrote:
> > Dear Shinya Kuribayashi,
> > 
> > In message<4EDB8475.1080305 at pobox.com>  you wrote:
> >>>> -pb1000                       mips        mips32      pb1x00          
> >>>>    -              au1x00      pb1x00:PB1000 +pb1000                  
> >>>>     mips        mips32      pb1x00              -              au1x00
> >>>>      pb1x00:PB1000,SYS_LITTLE_ENDIAN
> > 
> > ...
> > 
> >> But I don't see any reason CONFIG_SYS_LITTLE_ENDIAN is specified in
> >> boards.cfg.  Just putting it in configs/pb1000.h is enough, isn't it?
> > 
> > Agreed.  In almost all cases this should be done in the board config
> > file only.  Only if there are cases where a board suppors both LE and
> > BE configurations (is there any such board??) then we should need a
> > SYS_*_ENDIAN setting in boards.cfg (but even then, only one - not
> > two).
> 
> I did this because of dbau1550 and dbau1550_el. For the pb1000 I'll
> move it to the board config.
> 
> > Best regards,
> > 
> > Wolfgang Denk

Will we see V2 of this patch please?

Best regards,
Marek Vasut


More information about the U-Boot mailing list