[U-Boot] [PATCH V4] i.MX6: mx6q_sabrelite: add SATA bindings

Eric Nelson eric.nelson at boundarydevices.com
Tue May 1 23:58:31 CEST 2012


On 05/01/2012 02:11 PM, Marek Vasut wrote:
> Dear Eric Nelson,
>
>> On 05/01/2012 12:25 PM, Marek Vasut wrote:
>>> Dear Eric Nelson,
>>>
>>>> Signed-off-by: Eric Nelson<eric.nelson at boundarydevices.com>
>>>> ---
>>>> V2 has been stripped of the board-independent changes and
>>>> uses clrsetbits_le32() instead of twiddling bits by hand.
>>>>
>>>> V3 returns immediately from setup_sata() if enable_sata_clock()
>>>> returns an error.
>>>>
>>>> V4 removes extra #include and addresses a style issue as discussed
>>>> on the ML.
>>>
>>> It's still there ;-)
>>>
>>   >>  <snip>
>>>>
>>>> +			|IOMUXC_GPR13_SATA_PHY_2_TX_1P104V
>>>> +			|IOMUXC_GPR13_SATA_PHY_1_SLOW);
>>>> +
>>>>
>>>> +	return 0 ;<---- here :-)
>>
>> My eyes are clearly not as finely tuned as yours...
>
> 1 dioptry on left eye, lazy-eye blindness on the right one ;-)
>

For all that, you seem to see quite well!

>> <thought to self>
>> What are the odd that I could tweak checkpatch.pl
>> without introducing another style issue?
>> </thought to self>
>
> That'd be awesome.
>

Forthcoming...


More information about the U-Boot mailing list