[U-Boot] [PATCH V2] checkpatch: warn of whitespace before semicolon at end of line.

Marek Vasut marex at denx.de
Wed May 2 01:11:25 CEST 2012


Dear Eric Nelson,

> Signed-off-by: Eric Nelson <eric.nelson at boundarydevices.com>
> ---
>  tools/checkpatch.pl |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
> index 2048a44..0caffcb 100755
> --- a/tools/checkpatch.pl
> +++ b/tools/checkpatch.pl
> @@ -3139,6 +3139,12 @@ sub process {
>  			 "Statements terminations use 1 semicolon\n" . 
$herecurr);
>  		}
> 
> +# check for whitespace before semicolon (not allowed at end-of-line)
> +		if ($line =~ /\s+;$/) {
> +		    WARN("SPACEBEFORE_SEMICOLON",
> +			 "Blank before semicolon\n" . $herecurr);
> +		}
> +
>  # check for gcc specific __FUNCTION__
>  		if ($line =~ /__FUNCTION__/) {
>  			WARN("USE_FUNC",

Coolness, now let's also CC the linux (upstream) checkpatch author, to get it 
properly upstreamed :)

For me, add
Acked-by: Marek Vasut <marex at denx.de>

Best regards,
Marek Vasut


More information about the U-Boot mailing list