[U-Boot] [PATCH 1/2 v4] ARM : Add GPIO Driver and IOMUX definition for S3C2440

[Minkyu Kang]

Dear Marek,

On 2 May 2012 11:44, Marek Vasut <marex at denx.de> wrote:
>> > +int gpio_set_value(unsigned gpio, int value)
>> > +{
>> > +       unsigned l = readl(GPIO_FULLPORT(gpio));
>> > +       unsigned port = GPIO_FULLPORT(gpio);
>> > +
>> > +       /*
>> > +        * All GPIO Port have a configuration on
>> > +        * 2 bits excepted the first GPIO (A) which
>> > +        * have only 1 bit of configuration.
>> > +        */
>> > +       if (value)
>> > +               if (!GPIO_PORT(gpio))
>> > +                       l |= (0x1 << GPIO_BIT(gpio));
>> > +               else
>> > +                       l |= (0x3 << GPIO_BIT(gpio));
>> > +       else
>> > +               if (!GPIO_PORT(gpio))
>> > +                       l &= ~(0x1 << GPIO_BIT(gpio));
>> > +               else
>> > +                       l &= ~(0x3 << GPIO_BIT(gpio));
>>
>> Need brace at this if..else statement.
>
> I wanted to ask why, but ... C isn't python, good point ;-)

As I know, it's a rule of u-boot.. maybe. :)

Thanks.
Minkyu Kang.
-- 
from. prom.
www.promsoft.net