[U-Boot] [PATCH 2/3] omap4: do not enable fs-usb module

[R, Sricharan]

Hi Tero,
 Sorry my mailer thrashed my earlier email.
 resending it again.

On Wed, Apr 25, 2012 at 9:35 PM, Tero Kristo <t-kristo at ti.com> wrote:
> If this is done in the bootloader, the FS-USB will later be stuck into
> intransition state, which will prevent the device from entering idle.
>
> Signed-off-by: Tero Kristo <t-kristo at ti.com>
> ---
>  arch/arm/cpu/armv7/omap4/clocks.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/omap4/clocks.c b/arch/arm/cpu/armv7/omap4/clocks.c
> index dd694c4..c29531b 100644
> --- a/arch/arm/cpu/armv7/omap4/clocks.c
> +++ b/arch/arm/cpu/armv7/omap4/clocks.c
> @@ -378,7 +378,6 @@ void enable_basic_clocks(void)
>                &prcm->cm_l4per_gptimer2_clkctrl,
>                &prcm->cm_wkup_wdtimer2_clkctrl,
>                &prcm->cm_l4per_uart3_clkctrl,
> -               &prcm->cm_l3init_fsusb_clkctrl,
>                &prcm->cm_l3init_hsusbhost_clkctrl,
>                0
>        };
It should not have been in both places.
Removing here is fine.

> @@ -505,7 +504,6 @@ void enable_non_essential_clocks(void)
>                &prcm->cm_dss_dss_clkctrl,
>                &prcm->cm_sgx_sgx_clkctrl,
>                &prcm->cm_l3init_hsusbhost_clkctrl,
> -               &prcm->cm_l3init_fsusb_clkctrl,
>                0
>        };
>

 But instead of removing this here,how about removing the macro
 CONFIG_SYS_CLOCKS_ENABLE_ALL in omap4_common.h.
 This will get rid  of all non essential clocks which are currently enabled.

 One problem might be non-essential dplls should still be enabled in
 u-boot because kernel expects  all the dplls to be in locked state during
 boot without which it would  start throwing slew of warnings.

 This way we can get rid of your patch3 as well.

 I will send a patch to clean this first.

Thanks,
 Sricharan