[U-Boot] [PATCH 0/6] add zip command support for uboot

[Lei Wen]

On Wed, Apr 11, 2012 at 9:24 AM, Lei Wen <adrian.wenl at gmail.com> wrote:
> Hi Mike,
>
> On Wed, Apr 11, 2012 at 6:11 AM, Mike Frysinger <vapier at gentoo.org> wrote:
>> On Tuesday 10 April 2012 01:05:13 Lei Wen wrote:
>>> Hi Mike,
>>>
>>> On Tue, Apr 10, 2012 at 12:37 PM, Mike Frysinger <vapier at gentoo.org> wrote:
>>> > On Tuesday 03 April 2012 05:31:09 Lei Wen wrote:
>>> >> Hi Mike,
>>> >>
>>> >> On Tue, Apr 3, 2012 at 3:17 AM, Mike Frysinger <vapier at gentoo.org> wrote:
>>> >> > On Tue, Mar 27, 2012 at 04:04, Lei Wen <adrian.wenl at gmail.com> wrote:
>>> >> >> On Sun, Mar 25, 2012 at 11:53 PM,  <adrian.wenl at gmail.com> wrote:
>>> >> >>> From: Lei Wen <leiwen at marvell.com>
>>> >> >>>
>>> >> >>> This patch set add zip command support for uboot.
>>> >> >>> The first two patches import deflate and trees functions from zlib
>>> >> >>> 1.2.5 without any change. While the third patch did the necessary
>>> >> >>> change to make the import file could be built passed in uboot
>>> >> >>> environment.
>>> >> >>
>>> >> >> Any comments to this series?
>>> >> >
>>> >> > did you forward port the misc fixes/optimization that were done ?  or
>>> >> > did you just drop in the new code ?
>>> >>
>>> >> The fixes/optimization is already separated in different patch, as the
>>> >> 0004 in current series.
>>> >> Other file is just import as intact from zlib1.2.5, the 0001 and 0002
>>> >> patch.
>>> >
>>> > i don't understand what you mean.  0004 is "lib: zlib: remove the
>>> > limitation for cannot using 0 as start" and doesn't look like a fix that
>>> > was merged before.
>>> >
>>> >> > for example, cd514aeb996e2f7aefbe1f78481965d9d074aed4 is pretty
>>> >> > important
>>> >>
>>> >> I see. I try my best to keep the current modification history adding
>>> >> to the original zlib code.
>>> >
>>> > so you have maintained the bug fixes / optimizations ?  it isn't clear in
>>> > your response (at least to me).
>>>
>>> I see what your concerns...
>>> Yes, this change is not included in the zlib's own code, but just
>>> added by myself.
>>> Without this change, in uboot, we cannot zip from the start of ddr
>>> memory, since many
>>> platforms, at least from what I saw, their start ddr memory address is from
>>> 0.
>>
>> i think you've missed the point of my questions.  we aren't concerned with
>> changes you've written (such as patch 4/6 in this series), but bug fixes that
>> were added to the zlib code before you updated things.  updating to a newer
>> version and dropping previous fixes/optimizations isn't acceptable.
>
> I didn't overwrite the previous bug fix that existed in the uboot...
> The commit you point out is still there in lib/zlib/inffast.c
>
> What I am doing is just adding, not subtracting, nor overwriting...
> This patch set change is not to updating the zlib version...
> The previous inflate related stuff in uboot code is kept untouched.

ping...

Thanks,
Lei