[U-Boot] [PATCH] net: Multiple updates/enhancements to designware.c

[Stefan Roese]

Amit,

On Wednesday 09 May 2012 11:29:04 Amit Virdi wrote:
> > +++ b/include/configs/spear-common.h
> > @@ -38,6 +38,7 @@
> > 
> >   #define CONFIG_NET_MULTI
> >   #define CONFIG_PHY_RESET_DELAY			10000		/* 
in usec */
> >   #define CONFIG_DW_AUTONEG
> > 
> > +#define CONFIG_PHY_GIGE			/* Include GbE speed/duplex 
detection */
> 
> Shouldn't this come in a separate patch?

Not sure. This change is needed for this change in the designware driver to 
really work with 1000mbps links:

- Use common functions miiphy_speed()&  miiphy_duplex() to read
  link status from PHY.

Splitting it into a separate commit will result in a non working ethernet 
driver for such links. Even though it should still compile and be git 
bisectable. I would prefer to keep it in one patch.
 
> Otherwise, Acked-by: Amit Virdi <amit.virdi at st.com>

Thanks,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de