[U-Boot] [PATCH 02/13] M28EVK: Implement support for new board V2.0

Marek Vasut marex at denx.de
Wed May 9 12:31:00 CEST 2012


Dear Stefano Babic,

> On 01/05/2012 23:09, Marek Vasut wrote:
> > Signed-off-by: Marek Vasut <marex at denx.de>
> > Cc: Detlev Zundel <dzu at denx.de>
> > Cc: Fabio Estevam <fabio.estevam at freescale.com>
> > Cc: Stefano Babic <sbabic at denx.de>
> > Cc: Wolfgang Denk <wd at denx.de>
> > ---
> > 
> >  board/denx/m28evk/m28evk.c   |   20 +++++++++++++++++++-
> >  board/denx/m28evk/spl_boot.c |    8 ++++++--
> >  2 files changed, 25 insertions(+), 3 deletions(-)
> > 
> > diff --git a/board/denx/m28evk/m28evk.c b/board/denx/m28evk/m28evk.c
> > index 53df476..3d28ea8 100644
> > --- a/board/denx/m28evk/m28evk.c
> > +++ b/board/denx/m28evk/m28evk.c
> > @@ -90,6 +90,8 @@ int board_mmc_init(bd_t *bis)
> > 
> >  {
> >  
> >  	/* Configure WP as input. */
> >  	gpio_direction_input(MX28_PAD_AUART2_CTS__GPIO_3_10);
> > 
> > +	/* Turn on the power to the card. */
> > +	gpio_direction_output(MX28_PAD_PWM3__GPIO_3_28, 0);
> > 
> >  	return mxsmmc_initialize(bis, 0, m28_mmc_wp);
> >  
> >  }
> > 
> > @@ -103,10 +105,18 @@ int board_mmc_init(bd_t *bis)
> > 
> >  int fecmxc_mii_postcall(int phy)
> >  {
> > 
> > +#if	defined(CONFIG_DENX_M28_V11) || defined(CONFIG_DENX_M28_V10)
> 
> Do we really have no other way to get the board version ? We can use it
> if we have no other chance, but it seems quite nasty.

We don't ... but eventually, I'd be forced to add subsequent patch that drops 
support for v1.1 and v1.0 revisions anyway (as noone has them). I just want this 
in before removing it, so I can revert such patch (I still have v1.0 revision 
here) for myself.

> Stefano

Best regards,
Marek Vasut


More information about the U-Boot mailing list