[U-Boot] [PATCH 1/2] ARM: omap3: Set SPL stack size to 8KB, image to 54KB.

[Hiremath, Vaibhav]

On Tue, May 08, 2012 at 23:45:19, Rini, Tom wrote:
> On 05/08/2012 10:40 AM, Hiremath, Vaibhav wrote:
> > On Tue, May 08, 2012 at 22:59:31, Rini, Tom wrote:
> >> With older toolchains it is possible to not fit entirely into the 45KB
> >> that we had assigned to SPL.  Adjust to allow for 8KB of stack (which
> >> should be more than required) and 54KB of text/data.
> >>
> >
> > Tom,
> >
> > Can you provide more details on why 45Kb is not sufficient for SPL?
> 
> A combination of toolchains and enabled options will break this limit 
> (for example, beagle is size-broken once we enable i2c to whack the 
> twl4030 with ELDK4.2).  Rather than giving just one more KB to fix the 
> problem today, but run into it tomorrow, I'm pushing towards the biggest 
> split we can use.
> 

Exactly, I understand the need here. Can you please update the commit 
description with above details, the original patch commit description only 
talks about toolchain, but it is not only the toolchain, right?

Else looks ok to me.

Acked-by: Vaibhav Hiremath <hvaibhav at ti.com>

Thanks,
Vaibhav

> > You may have done some memory analysis on this; can you share that here?
> > Also, do we know how much ROM code is using out of 64KB of RAM?
> 
> We know that ROM loads us to 0x40200800 and we're allowed from there to 
> the end of SRAM to do as we please.  This is just adjusting the split 
> SPL makes into text+data and stack.
> 
> -- 
> Tom
>