[U-Boot] [PATCH v4 3/3] net: add eth_setenv_enetaddr_by_index()

Michael Walle michael at walle.cc
Fri May 11 23:01:49 CEST 2012


Am Freitag 11 Mai 2012, 21:25:27 schrieb Wolfgang Denk:
> Dear Michael Walle,
> 
> In message <1336671134-16342-4-git-send-email-michael at walle.cc> you wrote:
> > Signed-off-by: Michael Walle <michael at walle.cc>
> 
> How many boards will be using this code?
Hopefully more boars will use this function in the future, instead of messing 
around with the variable names themselves.

> Eventually this should be made configurable?
Given the above, i would keep it non-configurable if youre fine with that.

> 
> > +	sprintf(enetvar, index ? "%s%daddr" : "%saddr", base_name, index);
> 
> This should generate a warning: too many arguments for format.
Mh, nice catch. That was just copied from the eth_getenv_enetaddr_by_index() 
function. I'll fix all of them.

-- 
michael


More information about the U-Boot mailing list