[U-Boot] [PATCH] Ignore all Carriage Returns when importing an environment.

Alexander Holler holler at ahsoftware.de
Sat May 12 21:10:58 CEST 2012


Am 12.05.2012 20:37, schrieb Marek Vasut:
> Dear Alexander Holler,
>
>> Am 12.05.2012 18:08, schrieb Marek Vasut:
>>> Dear Alexander Holler,
>>>
>>>> Am 12.05.2012 16:46, schrieb Marek Vasut:
>>>>> Dear Alexander Holler,
>>>>>
>>>>>> Am 12.05.2012 08:17, schrieb Marek Vasut:
>>>>>>> Dear Alexander Holler,
>>>>>>>
>>>>>>>> This is used for compatibility with text files which are
>>>>>>>> using CRLF instead of LF as the end of a line.
>>>>>>>>
>>>>>>>> Signed-off-by: Alexander Holler<holler at ahsoftware.de>
>>>>>>>
>>>>>>> Why don't you run the file trough dos2unix or tr -d '\r' ?
>>>>>>
>>>>>> Because my files don't contain CRs. ;)
>>>>>
>>>>> s/you/someone else/ :)
>>>>
>>>> Try to explain a windows user that a text file should not contain
>>>> carriage returns and how he can achieve that.
>>>>
>>>> You'll do it once, maybe twice, than you will surrender. ;)
>>>
>>> But you're fixing the problem at a wrong place, aren't you? Besides,
>>> removing \r might harm some environments, don't you think?
>>
>> No, there is no other layer between the user and that function.
>>
>> Anyway, as already said, I don't care, just had this patch lying around
>> a year and I finally surrendered to post it here (in favor of those
>> users). But it seems I was right in not posting it. ;)
>
> Don't get me wrong, I'm not opposed to this patch, nor I want to demotivate you
> in further submissions. I'm just trying to figure out if actually surrending to
> crappy software on one side is a good move on our side. I'd prefer to get more
> oppinions from other people actually, I don't want the guilt to fall on me :-)

In the good old days (tm) with line printers and almost endless paper 
from dead trees, CRLF instead only LF as line endings in text files did 
made sense.

Regards,

Alexander


More information about the U-Boot mailing list