[U-Boot] [PATCH v4] Kirkwood: add lschlv2 and lsxhl board support

Mike Frysinger vapier at gentoo.org
Mon May 14 07:34:15 CEST 2012


On Thursday 10 May 2012 13:40:33 Michael Walle wrote:
> --- /dev/null
> +++ b/board/buffalo/lsxl/Makefile
>
> +clean:
> +	rm -f $(SOBJS) $(OBJS)
> +
> +distclean:	clean
> +	rm -f $(LIB) core *.bak .depend

dead code; please delete

> --- /dev/null
> +++ b/board/buffalo/lsxl/lsxl.c
>
> +int board_early_init_f(void)
> +{
> ...
> +	u32 kwmpp_config[] = {

this probably should be declared static.  otherwise, it generates the array on 
the stack at runtime doesn't it ?  look at objdump to see ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120514/bffb78f0/attachment.pgp>


More information about the U-Boot mailing list