[U-Boot] [PATCH 1/2] MSM7x27a:Add support for interrupt

[Srikanth Reddy]

Hi Wolfgang Denk,

could you please clarify on the below review comment.
________________________________________
From: Marek Vasut [marek.vasut at gmail.com]
Sent: Saturday, May 12, 2012 11:50 AM
To: u-boot at lists.denx.de
Cc: Srikanth Reddy; Mohamed Haneef; Shrinivas Sahukar; wd at denx.de
Subject: Re: [U-Boot] [PATCH 1/2] MSM7x27a:Add support for interrupt

Dear Srikanth Reddy Vintha,

>       * support for msm7x27a interrupt
>
> Signed-off-by: Srikanth Reddy Vintha <srikanth.reddy at lntinfotech.com>
> ---
>  arch/arm/cpu/armv7/msm7x27a/Makefile            |    1 +
>  arch/arm/cpu/armv7/msm7x27a/interrupts.c        |  136
> +++++++++++++++++++++++ arch/arm/include/asm/arch-msm7x27a/exclusion.h  |
>  42 +++++++
>  arch/arm/include/asm/arch-msm7x27a/interrupts.h |   39 +++++++
>  arch/arm/include/asm/arch-msm7x27a/irqs.h       |   98 ++++++++++++++++
>  board/qcom/msm7x27a_surf/msm7x27a_surf.c        |    2 +
>  include/configs/msm7x27a_surf.h                 |    2 +-
>  7 files changed, 319 insertions(+), 1 deletions(-)
>  create mode 100644 arch/arm/cpu/armv7/msm7x27a/interrupts.c
>  create mode 100644 arch/arm/include/asm/arch-msm7x27a/exclusion.h
>  create mode 100644 arch/arm/include/asm/arch-msm7x27a/interrupts.h
>  create mode 100644 arch/arm/include/asm/arch-msm7x27a/irqs.h
>
> diff --git a/arch/arm/cpu/armv7/msm7x27a/Makefile
> b/arch/arm/cpu/armv7/msm7x27a/Makefile index 5f493d7..19e7546 100644
> --- a/arch/arm/cpu/armv7/msm7x27a/Makefile
> +++ b/arch/arm/cpu/armv7/msm7x27a/Makefile
> @@ -34,6 +34,7 @@ COBJS-y     := board.o
>  COBJS-y      += timer.o
>  COBJS-y      += acpuclock.o
>  COBJS-y      += gpio.o
> +COBJS-$(CONFIG_USE_IRQ)      += interrupts.o
>
>  SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
>  OBJS := $(addprefix $(obj),$(COBJS-y) $(SOBJS-y))
> diff --git a/arch/arm/cpu/armv7/msm7x27a/interrupts.c
> b/arch/arm/cpu/armv7/msm7x27a/interrupts.c new file mode 100644
> index 0000000..cc45c4b
> --- /dev/null
> +++ b/arch/arm/cpu/armv7/msm7x27a/interrupts.c
> @@ -0,0 +1,136 @@
> +/*
> + * Copyright (c) 2008, Google Inc.
> + * All rights reserved.
> + *
> + * (C) Copyright 2012
> + * Larsen & Toubro Infotech Ltd. <www.lntinfotech.com>
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + *  * Redistributions of source code must retain the above copyright
> + *   notice, this list of conditions and the following disclaimer.
> + *  * Redistributions in binary form must reproduce the above copyright
> + *   notice, this list of conditions and the following disclaimer in
> + *   the documentation and/or other materials provided with the
> + *   distribution.
> + *  * Neither the name of Google, Inc. nor the names of its contributors
> + *   may be used to endorse or promote products derived from this
> + *   software without specific prior written permission.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
> + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
> + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
> + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
> + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
> + * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
> + * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> + * SUCH DAMAGE.

So this is not GPL? Until this is cleared (or WD claims otherwise), I'm not
reviewing further.

Btw if you submit any patches, make sure to CC the proper custodian so the
patches are not lost http://www.denx.de/wiki/U-Boot/Custodians


Is it compatible with GPL?, If not how do we overcome this.



Best regards,
 SrikanthR V