[U-Boot] [PATCH 1/4] tegra: remove some cruft from CONFIG_EXTRA_ENV_SETTINGS

Tom Warren TWarren at nvidia.com
Wed May 16 01:48:40 CEST 2012


Stephen,

> -----Original Message-----
> From: Stephen Warren [mailto:swarren at wwwdotorg.org]
> Sent: Tuesday, May 15, 2012 3:16 PM
> To: Tom Warren
> Cc: Simon Glass; u-boot at lists.denx.de; Stephen Warren
> Subject: [PATCH 1/4] tegra: remove some cruft from CONFIG_EXTRA_ENV_SETTINGS
> 
> From: Stephen Warren <swarren at nvidia.com>
> 
> console isn't used by anything, and the kernel should be set appropriately
> by whatever script is booting the kernel, not imposed by the bootloader.
> 
> mem might be useful, but the current value is pretty bogus, since it
> includes nvmem options that make no sense for an upstream kernel, and
> equally should not be required for any downstream kernel. Either way, this
> is also best left to the kernel boot script.
> 
> smpflag isn't used by anything, and again was probably intended to be a
> kernel command-line option better set by the kernel boot script.
> 
> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> ---
>  include/configs/tegra2-common.h |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/include/configs/tegra2-common.h b/include/configs/tegra2-
> common.h index 068ce88..cdd3093 100644
> --- a/include/configs/tegra2-common.h
> +++ b/include/configs/tegra2-common.h
> @@ -140,9 +140,6 @@
>  					"stderr=serial\0"
> 
>  #define CONFIG_EXTRA_ENV_SETTINGS \
> -	"console=ttyS0,115200n8\0" \
> -	"mem=" TEGRA2_SYSMEM "\0" \
You should remove the TEGRA2_SYSMEM #define from the board config files, too (seaboard.h, etc.)

Tom
> -	"smpflag=smp\0" \
>  	TEGRA2_DEVICE_SETTINGS
> 
>  #define CONFIG_LOADADDR		0x408000	/* def. location for kernel */
> --
> 1.7.0.4
-- 
nvpublic



More information about the U-Boot mailing list