[U-Boot] [PATCH V4 1/4] ARM: Define change_bit routine

[Scott Wood]

On 05/18/2012 01:00 AM, Amit Virdi wrote:
> From: Vipin KUMAR <vipin.kumar at st.com>
> 
> change_bit routine is left implementation dependent until now.
> This routine, which is basically a wrapper over __change_bit, is now defined for
> arm platforms in asm-arm/bitops.h
> 
> The Flexible Static memory controller driver, placed in
> mtd/nand/fsmc_nand.c needs this routine. FSMC is a memory controller
> peripheral from ST. The new driver implements the NAND interface part
> of the peripheral.
> 
> Signed-off-by: Vipin Kumar <vipin.kumar at st.com>
> Signed-off-by: Amit Virdi <amit.virdi at st.com>
> ---
>  arch/arm/include/asm/bitops.h |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/include/asm/bitops.h b/arch/arm/include/asm/bitops.h
> index 879e20e..7fe9c6d 100644
> --- a/arch/arm/include/asm/bitops.h
> +++ b/arch/arm/include/asm/bitops.h
> @@ -29,8 +29,6 @@ extern void set_bit(int nr, volatile void * addr);
>  
>  extern void clear_bit(int nr, volatile void * addr);
>  
> -extern void change_bit(int nr, volatile void * addr);
> -
>  static inline void __change_bit(int nr, volatile void *addr)
>  {
>  	unsigned long mask = BIT_MASK(nr);
> @@ -39,6 +37,11 @@ static inline void __change_bit(int nr, volatile void *addr)
>  	*p ^= mask;
>  }
>  
> +static inline void change_bit(int nr, volatile void *addr)
> +{
> +	__change_bit(nr, addr);
> +}
> +
>  static inline int __test_and_set_bit(int nr, volatile void *addr)
>  {
>  	unsigned long mask = BIT_MASK(nr);

While they're not used much, U-Boot does have interrupt support (at
least on powerpc -- not sure about ARM), so this should be atomic
against interrupts.

The NAND driver should be using __change_bit() instead.

-Scott