[U-Boot] [PATCH v3 01/10] net: Remove volatile from net API

Wolfgang Denk wd at denx.de
Mon May 21 21:05:25 CEST 2012


Dear Joe Hershberger,

In message <CANr=Z=ZiMqvn2vxp0_kMA76O091TJFu4ck6wVf7re3hEFMOk2g at mail.gmail.com> you wrote:
> 
> > While getting rid of volatile is a good thing in general, I am worried
> > about the test scope of this patch.
> 
> I was too.  That's why I asked for guidance:

Sorry, this was a misunderstanding then.

My expectation was that you wuld continue this patch series and clean
up the drivers, even though you cannot actually test these.

> > When are you planning to provide fixes for all these warnings?  As is,
> > the whole build is spoiled.  Or should we revert these patches?
> 
> I plan to submit patches for the boards I am able to test, but for
> reason that Mike suggested, I'm not sure it is wise to fix the warning
> unless it can be tested on hardware.

The rule is that he who breaks the code is also responsible to fix
it.  Please make the code at least compile-clean again.  Board
maintainers will have to help with actual testing.

Thanks.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Program maintenance is an entropy-increasing process,  and  even  its
most skilfull execution only delays the subsidence of the system into
unfixable obsolescence.       - Fred Brooks, "The Mythical Man Month"


More information about the U-Boot mailing list