[U-Boot] [PATCH 1/2] Add env vars describing U-Boot target board

[Wolfgang Denk]

Dear Stephen Warren,

In message <4FBA95F6.2020009 at wwwdotorg.org> you wrote:
>
> > Please make this optional - I don't want to have this enforced on all
> > boards, whether they want it or not.
> 
> Thanks for taking a look. The variables are already optional; you need
> to set CONFIG_ENV_VAR_* in order for common/env_*.c to add those
> variables to the default environment. Is that OK?

Ah, now I see what you mean.  But this is awkward.  Why do we need
both CONFIG_ENV_VAR_<foo> and <foo> ?  Also note that these BOARD_*
names are kind of polluting the name space.  I don't like that.

Just use a single variable with an appropriate value for each of
these settings.  And don't pass these on the command line (which is
already unreadable enough), but add it to the auto-generated config
file.

And make the whole feature user selectable - I think it makes no sense
if you have to individually enable all the 5 settings.


Hm... thinking about this, I also don't like the "board_*" prefix.
What you actually have are names, i. e. it should probably read
"soc_name" instead of "board_soc", etc.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Accident: A condition in which presence of mind is good, but  absence
of body is better.